Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Edit docs CI workflows to accommodate Docusaurus #50550

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Dec 23, 2024

Backports #48388

  • Edit docs CI workflows to accommodate Docusaurus
  • Copy the gravitational/teleport source into the content directory of a gravitational/docs-website clone and overwrite the git-update yarn script with a no-op command. With way, we can use the gravitational/teleport clone across multiple workflow steps (e.g., the prose linting step), and can identify a branch to pull using the actions/checkout defaults. Name the submodule directory current to match the expectations of the Docusaurus site.

  • Remove the Vercel preview workflow. After the docs engine migration, we'll no longer need to deploy a preview to Vercel in order to show docs authors what their potential changes look like on a rendered docs site.

Also fixes spelling errors caught by a later version of cspell.

  • Fix shellcheck issues in doc-tests.yaml script
  • Add exit commands for failed cds
  • Don't read from and write to package.json in the same pipeline
  • Add double quotes around variables
  • Use latest Docusaurus site config schema

  • Fix the Prepare docs site configuration step

  • Remove unneeded cds
  • Use the correct version name in the config.json prepared for the Docusaurus site

@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label Dec 23, 2024
@github-actions github-actions bot requested a review from taraspos December 23, 2024 15:26
@ptgott ptgott force-pushed the paul.gottschling/48388-bp-v17 branch 2 times, most recently from c9e7e1d to 333b190 Compare December 26, 2024 13:45
@ptgott ptgott force-pushed the paul.gottschling/48388-bp-v17 branch from 333b190 to d58e1db Compare December 27, 2024 20:45
Backports #48388

* Edit docs CI workflows to accommodate Docusaurus

- Copy the `gravitational/teleport` source into the `content` directory
  of a `gravitational/docs-website` clone and overwrite the `git-update`
  yarn script with a no-op command. With way, we can use the
  `gravitational/teleport` clone across multiple workflow steps (e.g.,
  the prose linting step), and can identify a branch to pull using the
  `actions/checkout` defaults. Name the submodule directory `current` to
  match the expectations of the Docusaurus site.

- Remove the Vercel preview workflow. After the docs engine migration,
  we'll no longer need to deploy a preview to Vercel in order to show
  docs authors what their potential changes look like on a rendered docs
  site.

Also fixes spelling errors caught by a later version of cspell.

* Fix shellcheck issues in doc-tests.yaml script

- Add `exit` commands for failed `cd`s
- Don't read from and write to `package.json` in the same pipeline
- Add double quotes around variables

* Use latest Docusaurus site config schema

* Fix the Prepare docs site configuration step

- Remove unneeded `cd`s
- Use the correct version name in the `config.json` prepared for the
  Docusaurus site
@ptgott ptgott force-pushed the paul.gottschling/48388-bp-v17 branch from d58e1db to adcefc7 Compare January 2, 2025 15:59
Copy link

github-actions bot commented Jan 2, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
paul.gottschling/48388-bp-v17 HEAD 1 ✅SUCCEED paul-gottschling-48388-bp-v17 2025-01-02 16:06:12

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from taraspos January 3, 2025 17:54
@ptgott ptgott added this pull request to the merge queue Jan 3, 2025
Merged via the queue into branch/v17 with commit 2966a50 Jan 3, 2025
40 checks passed
@ptgott ptgott deleted the paul.gottschling/48388-bp-v17 branch January 3, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants