[v17] Add SSO MFA prompt for WebUI MFA flows #50529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include sso channel ID in web mfa challenges. * Handle SSO MFA challenges. * Handle sso response in backend. * Handle non-webauthn mfa response for file transfer, admin actions, and app session. * Simplify useMfa with new helpers. * Fix lint. * Use AuthnDialog for file transfers; Fix json backend logic for file transfers. * Make useMfa and AuthnDialog more reusable and error proof. * Use AuthnDialog for App sessions. * Resolve comments. * Fix broken app launcher; improve mfaRequired logic in useMfa. * Fix AuthnDialog test. * Fix merge conflict with Db web access. * fix stories. * Refactor mfa required logic. * Address bl-nero's comments. * Address Ryan's comments. * Add useMfa unit test. * Fix story lint. * Replace Promise.withResolvers for compatiblity with older browers; Fix bug where MFA couldn't be retried after a failed attempt; Add extra tests.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ryanclark
approved these changes
Dec 23, 2024
zmb3
requested changes
Dec 23, 2024
| @@ -22,7 +22,7 @@ import { useParams } from 'react-router'; | |||
| import useAttempt from 'shared/hooks/useAttemptNext'; | |||
|
|
|||
| import { ButtonState } from 'teleport/lib/tdp'; | |||
| import { useMfa } from 'teleport/lib/useMfa'; | |||
| import { useMfaTty } from 'teleport/lib/useMfa'; | |||
There was a problem hiding this comment.
Pretty sure this breaks per-session MFA for desktops: see #50557
Requesting changes and adding a do-not-merge label to prevent this from getting in a release.
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Add full SSO MFA support for the WebUI.
Backport #49794 to branch/v17