Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert lib/auth/middleware to use slog #50521

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

rosstimothy
Copy link
Contributor

No description provided.

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Dec 20, 2024
@rosstimothy rosstimothy marked this pull request as ready for review December 20, 2024 21:41
Copy link
Contributor

@atburke atburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's one more:

logger := log.WithFields(logrus.Fields{"user_agent": ua, "identity": info.IdentityGetter.GetIdentity().Username, "version": clientVersionString, "addr": info.Conn.RemoteAddr().String()})

@rosstimothy
Copy link
Contributor Author

Looks like there's one more:

There ended up being a few still hanging around. My find and replace foo failed me on this one.

@rosstimothy rosstimothy requested a review from atburke December 20, 2024 22:28
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ryanclark December 21, 2024 01:06
@rosstimothy rosstimothy force-pushed the tross/auth_middleware_slog branch from c23a6d4 to 83c9824 Compare December 21, 2024 02:33
@rosstimothy rosstimothy added this pull request to the merge queue Dec 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2024
@rosstimothy rosstimothy added this pull request to the merge queue Dec 21, 2024
Merged via the queue into master with commit bbf7c1a Dec 21, 2024
41 checks passed
@rosstimothy rosstimothy deleted the tross/auth_middleware_slog branch December 21, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants