Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-agent-update: Use the RFD-184 webapi proxy update protocol by default when possible #50464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kube-agent-update: Use the RFD-184 webapi proxy update protocol by default when possible #50464

wants to merge 1 commit into from
+202 −23

Conversation

hugoShaka
Copy link
Contributor

Part of: RFD-184

Goal (internal): https://github.com/gravitational/cloud/issues/10289

This PR does two changes:

  • add the ability to configure the kube-agent-udpater to use both RFD-109 APIs and RFD-184 APIs to fetch version and choose when to update. If both are configured, RFD-184 takes precedence if the proxy supports it.
  • have the chart configure the kube-agent-updater RFD-184 APIs by default if the version server was already the proxy. We don't enable the new API if a custom versionServer is set to avoid breaking existing users.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-9hn260mmh-goteleport.vercel.app/docs

@hugoShaka hugoShaka added the no-changelog Indicates that a PR does not require a changelog entry label Dec 20, 2024
@hugoShaka hugoShaka force-pushed the hugo/kube-agent-updater-use-new-api branch from b1fac70 to f31a176 Compare December 20, 2024 15:26
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-9wrdwc7ne-goteleport.vercel.app/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis Awaiting requested review from marcoandredinis

@sclevine sclevine Awaiting requested review from sclevine

@vapopov vapopov Awaiting requested review from vapopov

@tigrato tigrato Awaiting requested review from tigrato

@bernardjkim bernardjkim Awaiting requested review from bernardjkim

@mmcallister mmcallister Awaiting requested review from mmcallister

@ptgott ptgott Awaiting requested review from ptgott

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation helm no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugoShaka