Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WorkloadIdentity resource to the Teleport Terraform Provider #50382

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Dec 18, 2024

Closes #49573

Adds support for the WorkloadIdentity resource to the Teleport Terraform Provider.

Copy link

🤖 Vercel preview here: https://docs-584ge98br-goteleport.vercel.app/docs

@strideynet strideynet added backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry labels Dec 19, 2024
@strideynet strideynet changed the title Strideynet/workload identity terraform provider Add support for WorkloadIdentity resource to the Teleport Terraform Provider Dec 19, 2024
Copy link

🤖 Vercel preview here: https://docs-cdmh6fu0m-goteleport.vercel.app/docs

Copy link

🤖 Vercel preview here: https://docs-5ryutgnb7-goteleport.vercel.app/docs

@public-teleport-github-review-bot

@strideynet - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

Copy link

🤖 Vercel preview here: https://docs-qhv1kxyhc-goteleport.vercel.app/docs

Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

Have you tested the prvoider against a real cluster?

Can you check that the preset role terraform-provider grants RW access to the workload identity kind? I think it's missing.

@strideynet
Copy link
Contributor Author

Have you tested the prvoider against a real cluster?

I have now 😅

Can you check that the preset role terraform-provider grants RW access to the workload identity kind? I think it's missing.

Looks like it's there - or - at least one of my other PRs has added this since you checked.

@strideynet strideynet added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@strideynet strideynet added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit 3796023 Dec 20, 2024
50 checks passed
@strideynet strideynet deleted the strideynet/workload-identity-terraform-provider branch December 20, 2024 18:56
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workload ID: Add Terraform support for WorkloadIdentity resource
5 participants