Adding Azure sync functionality which can be used by the Azure Fetcher #50367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
from
a590a2b to
9a73b76
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
a817501 to
e88e148
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
from
9a73b76 to
0d11394
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
from
e88e148 to
308bc2c
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
from
0d11394 to
f4c8928
Compare
mvbrock
commented
Dec 18, 2024
|
|
||
| package common | ||
|
|
||
| func DeduplicateSlice[T any](s []T, key func(T) string) []T { |
There was a problem hiding this comment.
From @marcoandredinis in #48843 (comment)
We should probably move this method to
lib/utils/slices/or similar, add a godoc and some test coverage.
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
2 times, most recently
from
0f0adcc to
8ef72c4
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure
branch
2 times, most recently
from
0a4c1f4 to
672ae8d
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
2 times, most recently
from
873db7c to
b2512a9
Compare
mvbrock
removed request for
marcoandredinis,
tigrato,
hugoShaka,
EdwardDowling and
smallinsky
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
from
b2512a9 to
1d807fb
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-disco-azure-sync
branch
from
1d807fb to
02e6652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of splitting #48843 into smaller PRs, and provides the Azure sync functionality which will be called by the Azure fetcher in the Discovery service.