set rollout start date and don't start updating if rollout just changed #50365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
force-pushed
the
hugo/rollout-start-date
branch
2 times, most recently
from
33d8eb0 to
47ce2f3
Compare
hugoShaka
force-pushed
the
hugo/rollout-start-date
branch
from
47ce2f3 to
6d855e5
Compare
hugoShaka
added
the
no-changelog
sclevine
approved these changes
Dec 19, 2024
vapopov
approved these changes
Dec 19, 2024
r0mant
approved these changes
Dec 19, 2024
public-teleport-github-review-bot
bot
removed request for
zmb3 and
bernardjkim
This commit does two changes: - the controller now sets the rollout start time when resetting the rollout - the controller will not start a group if the rollout changed during the maintenance window (checks if the rollout start time is in the window)
hugoShaka
force-pushed
the
hugo/rollout-start-date
branch
from
ee1ce53 to
e285c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289
This PR does two changes: