Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] DiscoveryConfig Status: update even when no resources are found #50331

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

marcoandredinis
Copy link
Contributor

Backport #49588 to v17

* DiscoveryConfig Status: update even when no resources are found

The DiscoveryService was not updating the DiscoveryConfigStatus when its
matchers didn't discovered any resource.

This would lead the user to think that there the DiscoveryConfig was not
being processed, when in fact it was.

* rename to FilterMapUnique

* rename to DiscoveryConfigName and GetDiscoveryConfigName

* fix var name
@marcoandredinis marcoandredinis added the no-changelog Indicates that a PR does not require a changelog entry label Dec 17, 2024
@github-actions github-actions bot requested review from atburke and r0mant December 17, 2024 12:06
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-50331.d212ksyjt6y4yg.amplifyapp.com

@marcoandredinis marcoandredinis added this pull request to the merge queue Dec 17, 2024
Merged via the queue into branch/v17 with commit 5294336 Dec 17, 2024
42 of 43 checks passed
@marcoandredinis marcoandredinis deleted the marco/v17/backport_49588 branch December 17, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport discovery no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants