Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 17.1.0-rc.1 #50319

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Release 17.1.0-rc.1 #50319

merged 1 commit into from
Dec 17, 2024

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Dec 16, 2024

No description provided.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-50319.d212ksyjt6y4yg.amplifyapp.com

@@ -19,13 +19,13 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>17.0.6</string>
<string>1.0</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a placeholder for all dev versions. @camscale is that right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The mac version number in this file does not support semver prerelease components - just 3 numbers. So all pre-releases get 1.0

@r0mant r0mant added the no-changelog Indicates that a PR does not require a changelog entry label Dec 16, 2024
@r0mant r0mant added this pull request to the merge queue Dec 16, 2024
@r0mant r0mant removed this pull request from the merge queue due to a manual request Dec 16, 2024
@r0mant r0mant added this pull request to the merge queue Dec 17, 2024
Merged via the queue into branch/v17 with commit c5c3fda Dec 17, 2024
45 of 46 checks passed
@r0mant r0mant deleted the release/17.1.0-rc.1 branch December 17, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport helm no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants