Add conversions to/from decisionpb.TLSIdentity #50308
Conversation
codingllama
added
the
no-changelog
|
|
||
| // TLSIdentityToTLSCA transforms a [decisionpb.TLSIdentity] into its | ||
| // equivalent [tlsca.Identity]. | ||
| func TLSIdentityToTLSCA(id *decisionpb.TLSIdentity) *tlsca.Identity { |
There was a problem hiding this comment.
@fspmarshall these are very similar to the helpers in our shared branch, with the major exception that I'm passing tlsca.Identity around as a pointer instead of by value - the struct is too big to keep copying around IMO (despite what a large part of the codebase seems to do).
I also don't distinguish between zero and nil for structs within tlsca.Identity, as they aren't distinguished there either. Semantics should be alright in the existing system (for example we'll handle an "empty" DeviceExtensions just fine).
| return apitraitconvert.ToProto(apiTraits) | ||
| } | ||
|
|
||
| func routeToAppFromProto(routeToApp *decisionpb.RouteToApp) tlsca.RouteToApp { |
There was a problem hiding this comment.
This returns tlsca.RouterToApp by value as that is how tlsca.Identity wants it. The inverse conversion (routeToAppToProto) will both take and return a pointer.
Same for other structs.
|
Friendly ping reviewers? |
There was a problem hiding this comment.
Would it be useful to put those conversion functions in api/ ?
Also, are we okay with the fact some fields are not deep copied and that editing the result of the conversion might change the original resource? (I think a few slices are passed as-is). Do we want to mention it in the godoc?
We can move if needed, for now I think this is fine (I don't see api/ code touching the protos here).
Seems OK too. I'll mention in godocs, that is a good suggestion. |
|
PTAL @hugoShaka. Friendly ping @fspmarshall @eriktate. |
public-teleport-github-review-bot
bot
removed the request for review
from eriktate
Add conversion methods between tlsca.Identity and decisionpb.TLSIdentity.
#49837