Update Slack integration to link directly to ACL review state #50247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiosion
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
kiosion
force-pushed
the
maxim/slackbot-link-to-acl-review
branch
from
4dc3cda to
684064b
Compare
bernardjkim
approved these changes
Dec 16, 2024
tigrato
reviewed
Dec 17, 2024
kiosion
force-pushed
the
maxim/slackbot-link-to-acl-review
branch
from
684064b to
ac59dc1
Compare
hugoShaka
approved these changes
Dec 20, 2024
|
Should this PR be backported? The corresponding |
Yeah, will work on backporting both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to e#5619. With those changes in place, this link will now immediately open the Review state, rather than just landing on the Access List view/edit route. If a review is not required, and the user has permission to review, there will be a banner with that info.