Adds FriendlyName support for IC resources #50127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcsc
added
no-changelog
smallinsky
reviewed
Dec 12, 2024
api/accessrequest/access_request.go
Outdated
Comment on lines
64
to
65
| resourceID.Kind = types.KindApp | ||
| resourceIDs = append(resourceIDs, resourceID) |
There was a problem hiding this comment.
Does the GetResourceDetails->GetResourcesByResourceIDs->GetResourcesByKind->mapResourceKindToListResourcesType is not better place to overwrite the kind ?
|
Where do we set friendly name? For naming consistency, can we add double quote on the account and permission set name. So that |
See gravitational/teleport.e#5693 |
tcsc
force-pushed
the
tcsc/idc-friendlynames
branch
from
0350b7c to
f9f3273
Compare
The IC Account and AccountAssignment resources do not have very user-friendly ids, making it hard to know what access is actually being granted when reviewing an access request. This patch adds support for - querying Identity Center accounts via `auth.ListResources` - generating a friendly resource name when reviewing an access request with IC resources.
tcsc
force-pushed
the
tcsc/idc-friendlynames
branch
from
f9f3273 to
fb656bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IC Account and AccountAssignment resources do not have very user-friendly
ids, making it hard to know what access is actually being granted when reviewing
an access request. And they are about to get even less friendly as we replace the
account name with a numeric ID.
This patch adds support for generating a friendly resource name when reviewing
an access request with IC resources.
Before:
After