Complete lib/srv conversion to slog #50124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/srvslog
branch
from
29b579b to
dcd6cda
Compare
rosstimothy
force-pushed
the
tross/srvslog
branch
from
dcd6cda to
fde1b30
Compare
rosstimothy
added
the
no-changelog
zmb3
approved these changes
Dec 17, 2024
codingllama
approved these changes
Dec 18, 2024
| @@ -121,6 +121,7 @@ linters-settings: | |||
| files: | |||
| - '**/api/**' | |||
| - '**/e/**' | |||
| - '**/lib/srv/**' | |||
There was a problem hiding this comment.
nit: Revert all changes to the file, except for this line? It's shifting blame for no particular reason.
|
Thanks for all the changes, Tim! |
public-teleport-github-review-bot
bot
removed request for
probakowski and
mvbrock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.