[v16] Remove ineffective CSRF check for /webconfirm #50102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WithAuthCookieAndCSRF checks only apply CSRF checks for state-changing (ie non-GET) requests. Since /webconfirm is always a GET request, the previous code gave the impression that CSRF tokens were validated which is not the case. No behavior change here - just being more explicit about what is being checked. There is no exploit due to not checking CSRF here due to the strict session verification performed on the confirmation token.
zmb3
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
avatus
approved these changes
Dec 11, 2024
codingllama
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50098 to branch/v16