[v17] chore: restructure vnet for windows support #49982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
the
no-changelog
github-actions
bot
added
size/md
tsh
ravicious
force-pushed
the
r7s/v17/backport-multi-port-backend
branch
from
0680d31 to
785004c
Compare
ravicious
force-pushed
the
r7s/v17/backport-49921-windows-vnet-restructure
branch
from
6909282 to
66b43fb
Compare
nklaassen
approved these changes
Dec 10, 2024
zmb3
approved these changes
Dec 10, 2024
Base automatically changed from
r7s/v17/backport-multi-port-backend
to
branch/v17
December 17, 2024 14:34
* chore: restructure vnet for windows support In preparation for adding Windows support to VNet, I have restructured the package/file structure a bit in a way that I think makes more sense and narrows the scope of OS-specific code. I also unexported some identifiers that did not need to be exported, in an attempt to make it more clear what is actually called from outside the vnet package. This commit does not make any functional changes except for adding the hidden `tsh vnet` and `tsh vnet-admin-setup` commands on windows that will just return errors. * fix renames in comments * switch reexec to escalate * fix-imports
ravicious
force-pushed
the
r7s/v17/backport-49921-windows-vnet-restructure
branch
from
66b43fb to
cf1e476
Compare
ravicious
deleted the
r7s/v17/backport-49921-windows-vnet-restructure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49921
Needs #49711 to be merged first for the v17.1 release.