disable spanner client metrics in tests #49803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
no-changelog
github-actions
bot
added
database-access
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to unblock the version bump #49767
For context, the "metrics" here in the newer version of the spanner client attempt to load application default credentials even though the test configured insecure test credentials.
The workaround is just to disable these metrics in tests.
I tested against a real spanner instance as well (using the latest spanner client version) to be sure that we don't need any changes outside of test code.
(in a real deployment you have to actually provide application default credentials anyway)
edit: I'll just add this to the version bump, since this field doesn't exist in the older version of the client.