Correct Vale lint errors in partials #49798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
added
no-changelog
github-actions
bot
requested review from
hugoShaka,
marcoandredinis and
mmcallister
tigrato
approved these changes
Dec 5, 2024
hugoShaka
approved these changes
Dec 5, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
marcoandredinis,
mmcallister,
zmb3 and
xinding33
ptgott
force-pushed
the
paul.gottschling/2024-12-04-lint-includes
branch
from
f78d33e to
078d6b7
Compare
marcoandredinis
approved these changes
Dec 9, 2024
ptgott
force-pushed
the
paul.gottschling/2024-12-04-lint-includes
branch
from
078d6b7 to
c8b66b8
Compare
One edge case is the `structure.architecture-h2` warning in `docs/pages/includes/database-access/rds-proxy.mdx`. This is technically correct, since the "How it works" section is before the "Prerequisites" section. We can determine whether this is a bug to fix in a separate change.
ptgott
force-pushed
the
paul.gottschling/2024-12-04-lint-includes
branch
from
c8b66b8 to
a8f9ad6
Compare
|
🤖 Vercel preview here: https://docs-m7g7zi5ic-goteleport.vercel.app/docs |
|
🤖 Vercel preview here: https://docs-n3uhxz1ou-goteleport.vercel.app/docs |
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One edge case is the
structure.architecture-h2warning indocs/pages/includes/database-access/rds-proxy.mdx. This is technically correct, since the "How it works" section is before the "Prerequisites" section. We can determine whether this is a bug to fix in a separate change.