Convert lib/srv/regular to use slog #49792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/regular_slog
branch
2 times, most recently
from
1865231 to
2d814c6
Compare
gabrielcorado
approved these changes
Dec 5, 2024
| server := &Server{ | ||
| hostname: "redhorse", | ||
| proxyMode: true, | ||
| logger: slog.New(logutils.DiscardHandler{}), |
There was a problem hiding this comment.
Should we use a test logger so that it gets the logs when we run the tests in verbose mode (-v)?
There was a problem hiding this comment.
I don't know that the logs would provide any additional/meaningful information for this test.
zmb3
approved these changes
Dec 6, 2024
This starts the transition of our SSH servers to use slog. The regular.Server has been converted to use slog, though there are still various logs emitted via the srv.ServerContext from the server which use logrus.
rosstimothy
force-pushed
the
tross/regular_slog
branch
from
2d814c6 to
e388ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the transition of our SSH servers to use slog. The regular.Server has been converted to use slog, though there are still various logs emitted via the srv.ServerContext from the server which use logrus.