Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest enabling PROXY protocol in DTW troubleshooting #49791

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Dec 4, 2024

Suggest enabling PROXY protocol as a way to solve "IP mismatch" errors.

Related to https://github.com/gravitational/cloud/issues/11289.

Copy link

github-actions bot commented Dec 4, 2024

🤖 Vercel preview here: https://docs-kfrw2c9hz-goteleport.vercel.app/docs

@codingllama
Copy link
Contributor Author

PTAL @tigrato.

Copy link

github-actions bot commented Dec 5, 2024

🤖 Vercel preview here: https://docs-a7c2hw0h6-goteleport.vercel.app/docs

@codingllama
Copy link
Contributor Author

Friendly ping @tigrato.

Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I am sorry, somehow I missed the email

@@ -12,3 +12,6 @@
- `tsh` v15.0.0 or newer. [Install tsh for Linux](../../installation.mdx#linux).
- To authenticate a Web UI session you need [Teleport Connect](
../../connect-your-client/teleport-connect.mdx#installation--upgrade)
- Correct end-user IP propagation to your Teleport deployment: X-Forwarded-For
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add https://goteleport.com/docs/reference/config/#reference-configurations as reference?

    # Enables the Proxy service to take client source IPs from the
    # "X-Forwarded-For" headers for web APIs.
    #
    # In order to prevent IP spoofing, it is important to ensure that the Proxy
    # service is placed behind a layer 7 load balancer or reverse proxy that
    # sets client IPs in the "X-Forwarded-For" headers. Requests with more than
    # one IPs will be rejected.
    trust_x_forwarded_for: false

We really need a doc to guide people ensuring the IP addresses are correct and how to configure them. That would be awesome using debug app access to validate them.

cc @ptgott

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for the links, PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49791.d3pp5qlev8mo18.amplifyapp.com

Copy link

github-actions bot commented Dec 6, 2024

🤖 Vercel preview here: https://docs-hzuc2fb01-goteleport.vercel.app/docs

@codingllama codingllama added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 8f4e8c9 Dec 6, 2024
42 checks passed
@codingllama codingllama deleted the codingllama/dtw-proxy-protocol branch December 6, 2024 19:09
@public-teleport-github-review-bot

@codingllama See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants