Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contacts Audit Events #49755

Merged
merged 17 commits into from
Dec 4, 2024
Merged

Conversation

mcbattirola
Copy link
Contributor

@mcbattirola mcbattirola commented Dec 4, 2024

This PR adds audit events for when contacts are created or deleted.

A future teleport.e PR will emit these events.

Screenshot 2024-12-04 at 09 02 41
Screenshot 2024-12-04 at 08 59 16

Contributes to https://github.com/gravitational/cloud/issues/10491

@mcbattirola mcbattirola changed the title Contacts Audit Events Add Contacts Audit Events Dec 4, 2024
@mcbattirola mcbattirola added the no-changelog Indicates that a PR does not require a changelog entry label Dec 4, 2024
@mcbattirola mcbattirola marked this pull request as ready for review December 4, 2024 13:01
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/md ui labels Dec 4, 2024
@github-actions github-actions bot requested review from gzdunek and ryanclark December 4, 2024 13:01
mcbattirola and others added 3 commits December 4, 2024 11:56
@mcbattirola mcbattirola enabled auto-merge December 4, 2024 16:16
@mcbattirola mcbattirola added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit e2c803b Dec 4, 2024
45 checks passed
@mcbattirola mcbattirola deleted the mcbattirola/contacts-audit-events branch December 4, 2024 17:22
mcbattirola added a commit that referenced this pull request Dec 23, 2024
* Add Contact resource; include it in default editor permissions and web ACL

* Add contacts to ACL test

* Improve godocs

Co-authored-by: Zac Bergquist <[email protected]>

* Add `contact` to the web user context

* Add contact audit events

* Lint fix

* Use string interpolation

Co-authored-by: Grzegorz Zdunek <[email protected]>

* Comment ContactType enum

* make grpc

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
mcbattirola added a commit that referenced this pull request Dec 23, 2024
* Add Contact resource; include it in default editor permissions and web ACL

* Add contacts to ACL test

* Improve godocs

Co-authored-by: Zac Bergquist <[email protected]>

* Add `contact` to the web user context

* Add contact audit events

* Lint fix

* Use string interpolation

Co-authored-by: Grzegorz Zdunek <[email protected]>

* Comment ContactType enum

* make grpc

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Dec 23, 2024
* Add Contacts Audit Events (#49755)

* Add Contact resource; include it in default editor permissions and web ACL

* Add contacts to ACL test

* Improve godocs

Co-authored-by: Zac Bergquist <[email protected]>

* Add `contact` to the web user context

* Add contact audit events

* Lint fix

* Use string interpolation

Co-authored-by: Grzegorz Zdunek <[email protected]>

* Comment ContactType enum

* make grpc

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>

* Blank line at the end of proto file

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Dec 23, 2024
* Add Contacts Audit Events (#49755)

* Add Contact resource; include it in default editor permissions and web ACL

* Add contacts to ACL test

* Improve godocs

Co-authored-by: Zac Bergquist <[email protected]>

* Add `contact` to the web user context

* Add contact audit events

* Lint fix

* Use string interpolation

Co-authored-by: Grzegorz Zdunek <[email protected]>

* Comment ContactType enum

* make grpc

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>

* Blank line at the end of proto file

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Dec 23, 2024
* Add Contact resource; include it in default editor permissions and web ACL

* Add contacts to ACL test

* Improve godocs



* Add `contact` to the web user context

* Add contact audit events

* Lint fix

* Use string interpolation



* Comment ContactType enum

* make grpc

---------

Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Grzegorz Zdunek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-log Issues related to Teleports Audit Log no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants