Add Account Assignment IDs to IC Account & App Permission Set Lists #49747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcsc
added
the
no-changelog
smallinsky
approved these changes
Dec 4, 2024
flyinghermit
approved these changes
Dec 4, 2024
r0mant
reviewed
Dec 4, 2024
|
|
||
| // AssignmentName is the name of an account assignment representing this | ||
| // permission set being assigned to the enclosing account. | ||
| string assignment_name = 4; |
There was a problem hiding this comment.
What is this "assignment name", is this the name of some Teleport internal object or something else? Also, a permission set can be assigned to multiple accounts - is this going to be an issue, or is this PermissionSetInfo is supposed to be used within an account object it's assigned to?
There was a problem hiding this comment.
Added explanatory comments
tcsc
force-pushed
the
tcsc/idc-add-assignments-to-apps
branch
from
18e1f3b to
3cc204d
Compare
|
🤖 Vercel preview here: https://docs-91o7jd8nl-goteleport.vercel.app/docs |
tcsc
force-pushed
the
tcsc/idc-add-assignments-to-apps
branch
from
3cc204d to
a3c8cdb
Compare
|
🤖 Vercel preview here: https://docs-eq1i0f6xo-goteleport.vercel.app/docs |
|
🤖 Vercel preview here: https://docs-9g0wroqw9-goteleport.vercel.app/docs |
Account Assignment resources represent potential Identity Center account assignments that will be created when a Teleport user is granted access to them via an Access Request. The UI needs to know which resources represent a given (Account, Permission Set) pair when building an access request, so this change allows Teleport to express this relationship in the enclosing Idenitity Center and App resources, rather than have the UI try and deduce it.
tcsc
force-pushed
the
tcsc/idc-add-assignments-to-apps
branch
from
f25e964 to
1e8f8bc
Compare
|
🤖 Vercel preview here: https://docs-acsc4s526-goteleport.vercel.app/docs |
tcsc
added a commit
that referenced
this pull request
Dec 5, 2024
…ists Backports #49747 Account Assignment resources represent potential Identity Center account assignments that will be created when a Teleport user is granted access to them via an Access Request. The UI needs to know which resources represent a given (Account, Permission Set) pair when building an access request, so this change allows Teleport to express this relationship in the enclosing Idenitity Center and App resources, rather than have the UI try and deduce it.
tcsc
added a commit
that referenced
this pull request
Dec 5, 2024
…ists Backports #49747 Account Assignment resources represent potential Identity Center account assignments that will be created when a Teleport user is granted access to them via an Access Request. The UI needs to know which resources represent a given (Account, Permission Set) pair when building an access request, so this change allows Teleport to express this relationship in the enclosing Idenitity Center and App resources, rather than have the UI try and deduce it.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…ists (#49820) Backports #49747 Account Assignment resources represent potential Identity Center account assignments that will be created when a Teleport user is granted access to them via an Access Request. The UI needs to know which resources represent a given (Account, Permission Set) pair when building an access request, so this change allows Teleport to express this relationship in the enclosing Idenitity Center and App resources, rather than have the UI try and deduce it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account Assignment resources represent potential Identity Center
account assignments that will be created when a Teleport user is
granted access to them via an Access Request.
The UI needs to know which resources represent a given (Account,
Permission Set) pair when building an access request, so this change
allows Teleport to express this relationship in the enclosing
Idenitity Center and App resources, rather than have the UI try
and deduce it.