Check if Postgres database exists prior to creation #49746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this change looks reasonable then I'll cut a dev build and test with that. |
|
How does a function that doesn't return an error prevent Teleport from starting? |
zmb3
reviewed
Dec 4, 2024
| // Performs a best-effort check to see if the specified database exists. It will return 'true' if the | ||
| // database is guaranteed to exist, false otherwise. An error will only be returned if it is known to | ||
| // not stem from the database not existing. | ||
| func CheckIfDatabaseExists(ctx context.Context, poolConfig *pgxpool.Config, log *slog.Logger) (bool, error) { |
There was a problem hiding this comment.
I would unexport this until such a time that it needs to be used in other packages.
|
|
||
| conn, err := pgx.ConnectConfig(ctx, poolConfig.ConnConfig) | ||
| if err != nil { | ||
| errMsg := fmt.Sprintf("Failed to verify that the %q database already exists", |
There was a problem hiding this comment.
Here and below - use structured log fields instead of sprintf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the auth server will fail to start with postgres backend if the Teleport postgres user does not have access to the
postgresdatabase. This attempts to remove this hard requirement by attempting to connect to the configuration-specified database first. This validates that the database exists, negating the need to attempt to create it, which in turn removes the need forpostgresdatabase access.There are no tests currently covering this package, and I'm not sure how to effectively add them.
Fixes #49745
changelog: Removed the need for
postgresdatabase access when the required databases for the Postgres backend already exist