Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused web API fields #49741

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Remove unused web API fields #49741

merged 1 commit into from
Dec 5, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Dec 4, 2024

  • sessionStreamPollPeriod was never used
  • The domain name field was written, but never read.
  • The wsIODeadline field was never consulted as Teleport referenced a constant in all circumstances

Note: needs gravitational/teleport.e#5621 to merge first.

@github-actions github-actions bot requested review from ravicious and rudream December 4, 2024 03:03
@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Dec 4, 2024
@zmb3 zmb3 force-pushed the zmb3/remove-unused-webapi-code branch from d69891d to 5adec78 Compare December 4, 2024 03:16
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rudream December 4, 2024 13:43
- sessionStreamPollPeriod was never used
- DomainName was written, but never read
- The wsIODeadline field was never consulted as Teleport referenced
  a constant in all circumstances
@zmb3 zmb3 force-pushed the zmb3/remove-unused-webapi-code branch from 5adec78 to 0fc7c6e Compare December 4, 2024 23:45
@r0mant
Copy link
Collaborator

r0mant commented Dec 5, 2024

/excludeflake *

@zmb3 zmb3 enabled auto-merge December 5, 2024 00:08
@zmb3 zmb3 added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@zmb3 zmb3 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit 5548311 Dec 5, 2024
42 checks passed
@zmb3 zmb3 deleted the zmb3/remove-unused-webapi-code branch December 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants