Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake TestRootUTMPEntryExists #49738

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Deflake TestRootUTMPEntryExists #49738

merged 1 commit into from
Dec 4, 2024

Conversation

atburke
Copy link
Contributor

@atburke atburke commented Dec 4, 2024

This change fixes TestRootUTMPEntryExists to use assert instead of require in a require.Eventually.

Fixes #49698.

@atburke atburke added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 backport/branch/v17 labels Dec 4, 2024
@github-actions github-actions bot requested review from kiosion and nklaassen December 4, 2024 01:03
@atburke atburke enabled auto-merge December 4, 2024 17:01
@atburke atburke added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 5669739 Dec 4, 2024
42 checks passed
@atburke atburke deleted the atburke/utmp-test-flake branch December 4, 2024 17:37
@public-teleport-github-review-bot
Copy link

@atburke See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

This was referenced Dec 4, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestRootUTMPEntryExists flakiness
3 participants
@atburke @marcoandredinis @zmb3