autoupdate: implement time-based strategy #49736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
force-pushed
the
hugo/rollout-timebased-strategy
branch
from
ff167f9 to
fa9819b
Compare
hugoShaka
force-pushed
the
hugo/rollout-progress-common
branch
from
8c41768 to
06d909d
Compare
hugoShaka
force-pushed
the
hugo/rollout-timebased-strategy
branch
from
fa9819b to
f4901f6
Compare
hugoShaka
force-pushed
the
hugo/rollout-progress-common
branch
from
06d909d to
296b736
Compare
hugoShaka
force-pushed
the
hugo/rollout-timebased-strategy
branch
from
f4901f6 to
6d0f8cb
Compare
hugoShaka
added
the
no-changelog
sclevine
approved these changes
Dec 11, 2024
| func (h *timeBasedStrategy) progressRollout(ctx context.Context, groups []*autoupdate.AutoUpdateAgentRolloutStatusGroup) error { | ||
| now := h.clock.Now() | ||
| // We always process every group regardless of the order. | ||
| var errors []error |
There was a problem hiding this comment.
Suggested change
| var errors []error | |
| var errs []error |
nit: conflicts with errors package, so looks a bit confusing below
vapopov
approved these changes
Dec 11, 2024
ryanclark
approved these changes
Dec 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from mvbrock
This commit implements the time-based rollout strategy describen in RFD 184. The autoupdate_agent_rollout controller will make the groups active based on their start days, start hour, and maintenance duration. Once the maintenance window is over, the group becomes DONE. In the DONE state, new agents will instalkl the target version but existing agents will no longer be told to actively update.
hugoShaka
force-pushed
the
hugo/rollout-timebased-strategy
branch
from
6d0f8cb to
d2e95a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289
Requires: #49735This PR imeplements the time-based rollout strategy.