fix: Avoid large unix socket paths on lib/service tests #49673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
no-changelog
|
Backports are aspirational, although probably worth having as the effort is likely low. |
strideynet
approved these changes
Dec 3, 2024
|
Friendly ping @eriktate ? |
marcoandredinis
approved these changes
Dec 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from eriktate
|
@zmb3 could I have an FTD exemption here, please? |
|
/excludeflake * |
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Dec 4, 2024
codingllama
added a commit
that referenced
this pull request
Dec 4, 2024
codingllama
added a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tests here keep failing on macOS due to the long unix socket path formed by t.TempDir(), so I swapped all DataDirs to use the helper.