Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove 2FA bypass (#47288)" #49671

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Dec 2, 2024

This reverts commit 1952dd8.

changelog: Restore ability to disable second factor authentication for local users.

@rosstimothy rosstimothy requested a review from zmb3 December 2, 2024 21:29
@rosstimothy rosstimothy marked this pull request as ready for review December 2, 2024 21:29
Copy link
Contributor

@nklaassen nklaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we reverting?

constants.go Outdated Show resolved Hide resolved
lib/modules/modules.go Outdated Show resolved Hide resolved
@rosstimothy
Copy link
Contributor Author

rosstimothy commented Dec 2, 2024

why are we reverting?

Some customers in restricted environments are not able to use the currently supported MFA devices. Until we add support for PIV/CAC cards we unfortunately need to allow this or risk losing customers.

@rosstimothy rosstimothy requested a review from nklaassen December 2, 2024 21:47
lib/auth/init.go Show resolved Hide resolved
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from zmb3 December 2, 2024 22:40
@rosstimothy rosstimothy force-pushed the tross/restore_2fa_bypass branch from 196a61b to c2bf77a Compare December 3, 2024 13:17
@rosstimothy rosstimothy enabled auto-merge December 3, 2024 13:18
@rosstimothy rosstimothy added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit 0286406 Dec 3, 2024
40 checks passed
@rosstimothy rosstimothy deleted the tross/restore_2fa_bypass branch December 3, 2024 14:12
@public-teleport-github-review-bot

@rosstimothy See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants