Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] deflake TestListUnifiedResources_WithLogins #49640

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[v17] deflake TestListUnifiedResources_WithLogins #49640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 28 additions & 20 deletions lib/auth/auth_with_roles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,7 @@ func TestGenerateUserCertsWithMFAVerification(t *testing.T) {
})
}
}

func TestGenerateUserCertsWithRoleRequest(t *testing.T) {
ctx := context.Background()
srv := newTestTLSServer(t)
Expand Down Expand Up @@ -5077,6 +5078,19 @@ func TestListUnifiedResources_WithLogins(t *testing.T) {
return srv.Auth().UnifiedResourceCache.IsInitialized()
}, 5*time.Second, 200*time.Millisecond, "unified resource watcher never initialized")

// create user and client
logins := []string{"llama", "fish"}
user, _, err := CreateUserAndRole(srv.Auth(), "user", nil /*mutated with role mutator*/, nil,
WithRoleMutator(
func(role types.Role) {
role.SetLogins(types.Allow, logins)
role.SetWindowsLogins(types.Allow, logins)
role.SetWindowsDesktopLabels(types.Allow, types.Labels{types.Wildcard: []string{types.Wildcard}})
role.SetAWSRoleARNs(types.Allow, logins)
}),
)
require.NoError(t, err)

for i := 0; i < 5; i++ {
name := uuid.New().String()
node, err := types.NewServerWithLabels(
Expand Down Expand Up @@ -5134,32 +5148,18 @@ func TestListUnifiedResources_WithLogins(t *testing.T) {
require.NoError(t, err)
}

// create user and client
logins := []string{"llama", "fish"}
user, role, err := CreateUserAndRole(srv.Auth(), "user", logins, nil)
require.NoError(t, err)
role.SetWindowsDesktopLabels(types.Allow, types.Labels{types.Wildcard: []string{types.Wildcard}})
role.SetWindowsLogins(types.Allow, logins)
role.SetAppLabels(types.Allow, types.Labels{types.Wildcard: []string{types.Wildcard}})
role.SetAWSRoleARNs(types.Allow, logins)
_, err = srv.Auth().UpdateRole(ctx, role)
require.NoError(t, err)

clt, err := srv.NewClient(TestUser(user.GetName()))
require.NoError(t, err)

var results []*proto.PaginatedResource
resultsC := make(chan []*proto.PaginatedResource, 1)

// Immediately listing resources can be problematic, given that not all were
// necessarily replicated in the unified resources cache. To cover this
// scenario, perform multiple attempts (if necessary) to read the complete
// list of resources.
require.EventuallyWithT(t, func(t *assert.CollectT) {
// Reset the resources list to avoid having items from previous
// iterations.
results = nil

var start string
var results []*proto.PaginatedResource
for {
resp, err := clt.ListUnifiedResources(ctx, &proto.ListUnifiedResourcesRequest{
Limit: 5,
Expand All @@ -5180,13 +5180,21 @@ func TestListUnifiedResources_WithLogins(t *testing.T) {

// Note: this number should be updated in case we add more resources to
// the setup loop.
assert.Len(t, results, 20)
}, 10*time.Second, 100*time.Millisecond, "unable to list all resources, expected 20 but got %d", len(results))
if !assert.Len(t, results, 20) {
return
}
resultsC <- results
}, 10*time.Second, 100*time.Millisecond, "unable to list all resources")

results := <-resultsC
// Check that only server, desktop, and app server resources contain the expected logins
for _, resource := range results {
expectPrincipals := func(resource *proto.PaginatedResource) bool {
isAWSConsoleApp := resource.GetAppServer() != nil && resource.GetAppServer().GetApp().IsAWSConsole()
if resource.GetNode() != nil || resource.GetWindowsDesktop() != nil || isAWSConsoleApp {
return resource.GetNode() != nil || resource.GetWindowsDesktop() != nil || isAWSConsoleApp
}

for _, resource := range results {
if expectPrincipals(resource) {
require.Empty(t, cmp.Diff(resource.Logins, logins, cmpopts.SortSlices(func(a, b string) bool {
return strings.Compare(a, b) < 0
})), "mismatch on expected logins list for resource %T", resource.Resource)
Expand Down
Loading