Fix variable duration race in lib/inventory tests #49630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rosstimothy
approved these changes
Dec 2, 2024
vapopov
approved these changes
Dec 2, 2024
public-teleport-github-review-bot
bot
removed request for
nklaassen and
GavinFrazar
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rosstimothy
deleted the
espadolini/variable-interval-heartbeats-test-fix
branch
|
@espadolini See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition in
TestSSHServerBasicsand otherlib/inventorytests that assume that theinstanceHBVariableDurationis decreased before the stream is gracefully closed by the server. Since there's no reason to not do that, this PR restores that behavior, changed in #49433.