[buddy] feat(charts): Give the possibility to add labels on more resources #49624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's possible to add labels on Jobs but not on Pods created by the Job. Let's allow it. Same problem on operator subchart for deployments and pod created by the deployment.
Signed-off-by: Tiago Silva <[email protected]>
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
marcoandredinis
approved these changes
Dec 2, 2024
|
🤖 Vercel preview here: https://docs-d4whle6um-goteleport.vercel.app/docs |
zmb3
approved these changes
Dec 2, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
mmcallister,
hugoShaka,
xinding33 and
ptgott
hugoShaka
approved these changes
Dec 2, 2024
|
🤖 Vercel preview here: https://docs-f0rpzx0rw-goteleport.vercel.app/docs |
tigrato
force-pushed
the
tigrato/pr-buddy-49501
branch
from
cdc3d2d to
7213e0f
Compare
tigrato
force-pushed
the
tigrato/pr-buddy-49501
branch
from
7213e0f to
745afae
Compare
|
🤖 Vercel preview here: https://docs-43rcxmqsi-goteleport.vercel.app/docs |
|
🤖 Vercel preview here: https://docs-3fvc4v2rs-goteleport.vercel.app/docs |
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible to add labels on Jobs but not on Pods created by the Job. Let's allow it.
Same problem on operator subchart for deployments and pod created by the deployment.
Buddy PR for #49501
Changelog: Add ability to configure resource labels in
teleport-cluster's operator sub-chart.