Bump the electron group with 2 updates #49610

dependabot · 2024-12-01T10:02:55Z

Bumps the electron group with 2 updates: electron and electron-builder.

Updates electron from 33.1.0 to 33.2.1

Release notes

electron v33.2.1

Release Notes for v33.2.1

Fixes

Fixed a crash that could occur when calling shell.readShortcutLink on Windows. #44803 (Also in 34)

Fixed an issue where WebContentsViews were being improperly removed. #44671 (Also in 31, 32, 34)

Fixed an issue where resize wasn't being emitted for single-pixel resizes on Windows. #44723 (Also in 32, 34)

Fixed an issue where a utilityProcess pid would not be undefined after exit. #44694 (Also in 32, 34)

Fixed an issue where buttons shown under the Window Controls Overlay API were missing tooltips. #44757 (Also in 32, 34)

Fixed an issue where the webContents context-menu event was not emitted when using -webkit-app-region: drag. #44800 (Also in 32, 34)

Fixed an issue where the windows control overlay was unexpectedly visible in fullscreen on Linux. #44640 (Also in 31, 32, 34)

Fixed crash in net api when utility process exits. #44729 (Also in 32, 34)

Fixed segfault when moving WebContentsView between BrowserWindows. #44613 (Also in 31, 32, 34)

Fixed theme does not work in DevTools. #44635 (Also in 32, 34)

Fixed update file extension bug. #44771 (Also in 34)

Return 0 exit code for normal termination of the utility process. #44732 (Also in 32, 34)

Other Changes

Fixed an issue where a deprecation warning was being incorrectly emitted for frameless windows on macOS. #44767 (Also in 34)

Fixed drag-and-drop session being canceled on wayland with empty dragData. #44753 (Also in 32)

Security: backported fix for CVE-2024-11110. #44647

Updated Chromium to 130.0.6723.137. #44781

Updated Node.js to v20.18.1. #44780

electron v33.2.0

Release Notes for v33.2.0

Features

Added GPU accelerated shared texture offscreen rendering. #44511

Other Changes

Updated Chromium to 130.0.6723.118. #44591

Commits

cd6e3d7 refactor: fix modernize-return-braced-init-list warnings (#44857)
7152209 fix: modernize-use-using clang-tidy warnings (#44836)
51e31de fix: modernize-use-nodiscard clang-tidy warnings (#44832)
fe3467e docs: correct stable release dates for v34.0.0 (#44830)
d0e24fc fix: clang-tidy performance-inefficient-vector-operation warnings (33-x-y) ...
3483cd6 refactor: remove unnecessary constructor code (#44825)
1ef8b47 fix: remove unused local variables (#44822)
71c1149 docs: update new GitHub issue link (#44810)
bd5c8d7 fix: crash calling shell.readShortcutLink (#44803)
52b5d8a fix: big endian bug in V8 serialization (#44796)
Additional commits viewable in compare view

Updates electron-builder from 25.1.7 to 25.1.8

Release notes

Sourced from electron-builder's releases.

v25.1.8

What's Changed

chore: update test snapshot for latest 1.0.4 electron-builder-test release by @mmaietta in electron-userland/electron-builder#8555

fix: Path does not end with the package name by @beyondkmp in electron-userland/electron-builder#8560

chore(deploy): Release by @github-actions in electron-userland/electron-builder#8561

Full Changelog: https://github.com/electron-userland/electron-builder/compare/[email protected]@25.1.8

Changelog

Sourced from electron-builder's changelog.

25.1.8

Patch Changes

Updated dependencies [4ff778eefd9089b3b38b67156eb39e8cf57fdd83]:

[email protected]

[email protected]

Commits

1d61d6f chore(deploy): Release v25.1.8 (#8561)
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

ravicious · 2024-12-03T16:37:07Z

I'll make a tag build once #49613 gets merged and dependabot updates this PR.

Edit: https://github.com/gravitational/teleport.e/actions/runs/12144336818

Bumps the electron group with 2 updates: [electron](https://github.com/electron/electron) and [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder). Updates `electron` from 33.1.0 to 33.2.1 - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v33.1.0...v33.2.1) Updates `electron-builder` from 25.1.7 to 25.1.8 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/[email protected]/packages/electron-builder) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-minor dependency-group: electron - dependency-name: electron-builder dependency-type: direct:development update-type: version-update:semver-patch dependency-group: electron ... Signed-off-by: dependabot[bot] <[email protected]>

ravicious · 2024-12-04T09:28:31Z

The build failed during notarization:

  • skipped macOS notarization  reason=`notarize` options were unable to be generated
  ⨯ Failed to notarize via notarytool.  Failed with unexpected result: 

  failedTask=build stackTrace=Error: Failed to notarize via notarytool.  Failed with unexpected result: 
                                                                                 at /Users/runner/work/teleport.e/teleport.e/node_modules/.pnpm/@[email protected]/node_modules/@electron/notarize/src/notarytool.ts:115:13
    at Generator.next (<anonymous>)
    at fulfilled (/Users/runner/work/teleport.e/teleport.e/node_modules/.pnpm/@[email protected]/node_modules/@electron/notarize/lib/notarytool.js:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
/Users/runner/work/teleport.e/teleport.e/web/packages/teleterm:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @gravitational/[email protected] package: `electron-builder build --config electron-builder-config.js --publish never -c.extraMetadata.name=teleport-connect "-c.extraMetadata.version=18.0.0-dev.ravicious.2" "--universal"`

https://github.com/gravitational/teleport.e/actions/runs/12144336818/job/33864767433#step:15:329

It might be a one-off thing, but I'll also explicitly disable notarization through electron-builder since we use our own script for that.

Edit: Another build is in progress: https://github.com/gravitational/teleport.e/actions/runs/12156853886

Otherwise the output during a build would just say this: > skipped macOS notarization reason=`notarize` options were set explicitly `false` which could give the wrong impression that notarization was not done at all.

ravicious

Ran the checklists on all four systems and it seems to work fine.

gzdunek

Thanks, @ravicious!

public-teleport-github-review-bot · 2024-12-12T07:52:39Z

@dependabot[bot] See the table below for backport results.

Branch	Result
branch/v15	Failed
branch/v16	Failed
branch/v17	Failed

dependabot bot added dependencies Pull requests that update a dependency file no-changelog Indicates that a PR does not require a changelog entry ui labels Dec 1, 2024

dependabot bot requested review from avatus, bl-nero, gzdunek, kimlisa, ravicious, rudream and ryanclark December 1, 2024 10:02

ravicious removed request for avatus, ryanclark, bl-nero, kimlisa and rudream December 3, 2024 16:34

dependabot bot force-pushed the dependabot/npm_and_yarn/electron-34c319bfbd branch from 75e0a9a to a312e89 Compare December 3, 2024 16:46

ravicious added 2 commits December 4, 2024 10:29

Turn off electron-builder's notarization

d28a378

Add console.log to notarize.js

c6c579f

Otherwise the output during a build would just say this: > skipped macOS notarization reason=`notarize` options were set explicitly `false` which could give the wrong impression that notarization was not done at all.

ravicious approved these changes Dec 11, 2024

View reviewed changes

ravicious added backport/branch/v15 backport/branch/v16 backport/branch/v17 labels Dec 11, 2024

gzdunek approved these changes Dec 12, 2024

View reviewed changes

gzdunek enabled auto-merge December 12, 2024 07:38

gzdunek added this pull request to the merge queue Dec 12, 2024

Merged via the queue into master with commit b757ce9 Dec 12, 2024
41 checks passed

gzdunek deleted the dependabot/npm_and_yarn/electron-34c319bfbd branch December 12, 2024 07:50

This was referenced Dec 12, 2024

Fix electron-builder peer deps #50129

Merged

[v17] Bump the electron group with 2 updates #50144

Merged

[v16] Bump the electron group with 2 updates #50146

Merged

[v15] Bump the electron group with 2 updates #50148

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump the electron group with 2 updates #49610

Bump the electron group with 2 updates #49610

dependabot bot commented on behalf of github Dec 1, 2024 •

edited

Loading

ravicious commented Dec 3, 2024 •

edited

Loading

ravicious commented Dec 4, 2024 •

edited

Loading

ravicious left a comment

gzdunek left a comment

public-teleport-github-review-bot bot commented Dec 12, 2024

Bump the electron group with 2 updates #49610

Bump the electron group with 2 updates #49610

Conversation

dependabot bot commented on behalf of github Dec 1, 2024 • edited Loading

electron v33.2.1

Release Notes for v33.2.1

Fixes

Other Changes

electron v33.2.0

Release Notes for v33.2.0

Features

Other Changes

v25.1.8

What's Changed

25.1.8

Patch Changes

ravicious commented Dec 3, 2024 • edited Loading

ravicious commented Dec 4, 2024 • edited Loading

ravicious left a comment

Choose a reason for hiding this comment

gzdunek left a comment

Choose a reason for hiding this comment

public-teleport-github-review-bot bot commented Dec 12, 2024

dependabot bot commented on behalf of github Dec 1, 2024 •

edited

Loading

ravicious commented Dec 3, 2024 •

edited

Loading

ravicious commented Dec 4, 2024 •

edited

Loading