Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestDynamicIdentityFileCreds for Go 1.23 #49597

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Nov 29, 2024

Go 1.23 changed the behavior of tls.X509KeyPair and tls.LoadX509KeyPair to populate the certificate leaf, which makes the assertions on TestDynamicIdentityFileCreds fail.

The PR changes the test to expect a nil leaf, which matches the behavior of the code under test.

Closes #49541.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Nov 29, 2024
@codingllama
Copy link
Contributor Author

This keeps failing for me locally so I took the easy way out while the more high-level discussion of "should our helpers set the leaf" progresses.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49597.d3pp5qlev8mo18.amplifyapp.com

@codingllama codingllama enabled auto-merge December 2, 2024 14:05
@codingllama codingllama added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 90076ba Dec 2, 2024
45 of 46 checks passed
@codingllama codingllama deleted the codingllama/TestDynamicIdentityFileCreds branch December 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestDynamicIdentityFileCreds breaks under Go 1.23
3 participants