Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Gracefully handle a disconnected hardware key in Connect #49579

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Nov 29, 2024

Backport #47404 to branch/v16

I also backported #48964 to prevent text overflow in the profile switcher.

* Gracefully handle loading profile status errors in `ListRootClusters`

* Start headless watcher only after we successfully synchronize the given root cluster

Doing this on the frontend side gives us more control over when the watcher should be started.

* `i` -> `cluster`

* Improve `StartHeadlessWatcher` comment

* Fix teleterm test

(cherry picked from commit 6797ffe)
…#48964)

* Make identity container fill 100% width of popover to prevent user + cluster name overflow

* Add min-width=0 to allow the container to shrink its content so `ProfileStatusError` doesn't overflow it

* Make `profileStatusError` text longer in a story

(cherry picked from commit 5a362d4)
@gzdunek gzdunek added the no-changelog Indicates that a PR does not require a changelog entry label Nov 29, 2024
@github-actions github-actions bot requested review from avatus and ryanclark November 29, 2024 12:28
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49579.d212ksyjt6y4yg.amplifyapp.com

# Conflicts:
#	gen/proto/go/teleport/lib/teleterm/v1/cluster.pb.go
#	web/packages/teleterm/src/ui/TopBar/Identity/IdentityList/IdentityList.tsx
@gzdunek gzdunek enabled auto-merge December 3, 2024 13:46
@gzdunek gzdunek added this pull request to the merge queue Dec 3, 2024
Merged via the queue into branch/v16 with commit d4b6199 Dec 3, 2024
44 checks passed
@gzdunek gzdunek deleted the gzdunek/backport-47404/v16 branch December 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants