Hostname validation: document invalid hostnames #49549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
marcoandredinis
temporarily deployed
to
vercel
GitHub Actions
Inactive
github-actions
bot
requested review from
kiosion,
mmcallister,
ptgott,
r0mant,
timothyb89,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-1bsn9mh1f-goteleport.vercel.app/docs |
marcoandredinis
force-pushed
the
marco/clarify_invalid_hostnames
branch
from
606f1cf to
0ab6d12
Compare
marcoandredinis
temporarily deployed
to
vercel
GitHub Actions
Inactive
|
🤖 Vercel preview here: https://docs-3tbydhn88-goteleport.vercel.app/docs |
zmb3
approved these changes
Dec 2, 2024
marcoandredinis
force-pushed
the
marco/clarify_invalid_hostnames
branch
from
0ab6d12 to
b275b9e
Compare
marcoandredinis
temporarily deployed
to
vercel
GitHub Actions
Inactive
|
🤖 Vercel preview here: https://docs-nrykc4m3f-goteleport.vercel.app/docs |
ptgott
approved these changes
Dec 2, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
timothyb89,
mmcallister,
xinding33 and
kiosion
|
@marcoandredinis See the table below for backport results.
|
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib we use for validation only accepts lower case hostnames.
Updated the docs accordingly as well as the tests.