Move tooltips to the design package #49544
Conversation
Adds a model-level validation capability to our validation library.
They will be later required in the SlideTabs component
bl-nero
added
the
no-changelog
There was a problem hiding this comment.
Do you know what's the difference between HoverTooltip and ToolTipInfo? They seem to behave identical in the story 🤔 Maybe we should remove or deprecate one of them?
There was a problem hiding this comment.
They behave in a similar, if not identical manner, but they have different interfaces, because ToolTipInfo is a specialized case for displaying icons with tooltips. It's used in places like field labels. I was there once, when I was working on modernizing these, and I also had a brief reflex to unify them. To my surprise, the result of my unification attempt was uglier and more complex than the original, and required a lot of refactoring of its usage, so I decided to keep these two separate.
There was a problem hiding this comment.
What would you think of renaming TooltipInfo to IconTooltip then? I'm not sure if Info provides any value.
But if it's too much for this PR we can leave it as is.
There was a problem hiding this comment.
Seems like a good idea. I'll do it.
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
* Validation Adds a model-level validation capability to our validation library. * Move tooltips to the design package They will be later required in the SlideTabs component * Review * Also, rename the tooltip directory * Also, rename the tooltip component * review * Never return undefined from useValidation()
* Validation Adds a model-level validation capability to our validation library. * Move tooltips to the design package They will be later required in the SlideTabs component * Review * Also, rename the tooltip directory * Also, rename the tooltip component * review * Never return undefined from useValidation()
They will be later required in the
SlideTabscomponent, and that one is indesign, too.Requires #49543 (not on its own, but because it's a part of a larger PR train)
Followed up by #49545
Followed up by https://github.com/gravitational/teleport.e/pull/5593 (cleanup)
Contributes to #46612