Fix types of custom CSS props #49539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
the
no-changelog
ryanclark
approved these changes
Nov 28, 2024
bl-nero
approved these changes
Nov 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on UI for multi-port, I figured out that the generic argument that
StyleFunctionrequires is equivalent to "The props received by the component where the style function is going to be consumed". In most cases it's justComponentProps<'div'>, so I replaced any instances ofStyleFunction<any>withStyleFunction<ComponentProps<'div'>>.