Integration Discovery Rules: endpoint that returns all the rules #49514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
discover
marcoandredinis
force-pushed
the
marco/integration_rules_endpoint
branch
2 times, most recently
from
3b3425d to
2feaecc
Compare
ravicious
approved these changes
Nov 29, 2024
|
|
||
| ret.NextKey = nextToken | ||
|
|
||
| if nextToken == "" || len(ret.Rules) > maxPerPage { |
There was a problem hiding this comment.
So I suppose it can fetch more rules than maxPerPage, but I assume we're okay with that?
There was a problem hiding this comment.
Yeah, I think so.
This works as a soft limit.
Otherwise, we might need to stop adding elements in the middle of the loop, which would turn the nextToken something composed of the DiscoveryConfig previous nextToken and some other value indicating where we stopped (some index).
marcoandredinis
force-pushed
the
marco/integration_rules_endpoint
branch
from
2feaecc to
83e6a93
Compare
This PR adds a new endpoint that returns all the discovery rules that exist for a given Integration. It will include what was the last time the rule was used to fetch resources, so that users can see stale rules and act upon it. The endpoint supports filtering by the resource type to ensure the UI only requests a subset of the rules, depending on the screen the user is visiting (eg, EC2, RDS or EKS).
marcoandredinis
force-pushed
the
marco/integration_rules_endpoint
branch
from
83e6a93 to
4568fb7
Compare
marcoandredinis
added
the
no-changelog
|
@kiosion Can you please take a lookg when you get a chance? |
r0mant
approved these changes
Dec 5, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Dec 6, 2024
) * Integration Discovery Rules: endpoint that returns all the rules This PR adds a new endpoint that returns all the discovery rules that exist for a given Integration. It will include what was the last time the rule was used to fetch resources, so that users can see stale rules and act upon it. The endpoint supports filtering by the resource type to ensure the UI only requests a subset of the rules, depending on the screen the user is visiting (eg, EC2, RDS or EKS). * use discovery rule
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
) (#49869) * Integration Discovery Rules: endpoint that returns all the rules This PR adds a new endpoint that returns all the discovery rules that exist for a given Integration. It will include what was the last time the rule was used to fetch resources, so that users can see stale rules and act upon it. The endpoint supports filtering by the resource type to ensure the UI only requests a subset of the rules, depending on the screen the user is visiting (eg, EC2, RDS or EKS). * use discovery rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint that returns all the discovery rules that exist for a given Integration.
It will include what was the last time the rule was used to fetch resources, so that users can see stale rules and act upon it.
The endpoint supports filtering by the resource type to ensure the UI only requests a subset of the rules, depending on the screen the user is visiting (eg, EC2, RDS or EKS).
Demo:
curl ... 'https://proxy.example.com/v1/webapi/sites/my-cluster/integrations/teleportdev/discoveryrules'