Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Add support for requiring reason for access requests #49513

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kopiczko
Copy link
Contributor

@kopiczko kopiczko commented Nov 27, 2024

Backport #49124 to branch/v17

changelog: Added support for requiring reason for access requests (with a new role.spec.allow.request.reason.mode setting).

@kopiczko kopiczko force-pushed the kopiczko/backport-49124-branch/v17 branch from ca343d9 to 9570962 Compare November 27, 2024 17:51
@kopiczko kopiczko marked this pull request as ready for review November 27, 2024 20:24
@kopiczko kopiczko added the no-changelog Indicates that a PR does not require a changelog entry label Nov 27, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant November 28, 2024 10:51
@kopiczko kopiczko added this pull request to the merge queue Nov 28, 2024
Merged via the queue into branch/v17 with commit 5db02ce Nov 28, 2024
45 of 46 checks passed
@kopiczko kopiczko deleted the kopiczko/backport-49124-branch/v17 branch November 28, 2024 11:18
@kopiczko kopiczko removed the no-changelog Indicates that a PR does not require a changelog entry label Dec 4, 2024
@zmb3
Copy link
Collaborator

zmb3 commented Dec 11, 2024

@doggydogworld this has a changelog entry and was merged prior to the 17.0.3 release but didn't make it into the changelog - any idea why?

@kopiczko
Copy link
Contributor Author

@doggydogworld this has a changelog entry and was merged prior to the 17.0.3 release but didn't make it into the changelog - any idea why?

Yes. I messed up. I added it after merge. Sorry for the confusion. I also added the entry manually to the release https://github.com/gravitational/teleport/releases/tag/v17.0.3

@zmb3
Copy link
Collaborator

zmb3 commented Dec 11, 2024

No problem @kopiczko - could you also PR to CHANGELOG.md on branch/v17?

@kopiczko
Copy link
Contributor Author

branch/v17 changelog update PR #50128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants