-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[teleport-update] status subcommand #49308
Conversation
if err != nil { | ||
return trace.Errorf("failed to write teleport-update systemd config files: %w", err) | ||
return nil, trace.Errorf("failed to open: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider trace.ConvertSystemErr
for filesystem operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like that would convert the os/fs errors to trace-specific types that this package isn't looking for? Or is the primary intent to avoid stack traces for these errors?
I haven't found any guidelines on when trace
should be used or avoided. I try to avoid everything besides trace.Errorf
and trace.Wrap
(unless I'm writing code that is called by something that expects a specific trace error). That said, happy to follow repo conventions.
ef4c39c
to
79609c4
Compare
79609c4
to
214f13e
Compare
This PR implements the
teleport-update status
subcommand. Running this command outputs a combination of local and remote status fields that describe the state of agent auto-updates from this agent's perspective.Additionally, this PR moves all config management logic into
config.go
. The previous contents ofconfig.go
are now insetup.go
.Depends on: #49307
The
teleport-update
binary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/var/lib/teleport/versions
.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289
Example: