Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-agent-updater: add RFD-184 trigger and version getter #49297

Merged
merged 6 commits into from
Dec 4, 2024
Merged

kube-agent-updater: add RFD-184 trigger and version getter #49297

merged 6 commits into from
Dec 4, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Nov 20, 2024 •
edited
Loading

This PR adds:

  • a new maintenance trigger checking the /find endpoint as described in RFD-184
  • a version getter checking the /find endpoint as described in RFD-184
  • a composite maintenance trigger that chains several triggers, this will be used to have updater try the new API first, and fallback to the old API
  • a composite version getter that chains several triggers, this will be used to have updater try the new API first, and fallback to the old API

Requires #49296
Goal (internal): https://github.com/gravitational/cloud/issues/10289

Base automatically changed from hugo/reusable-webproxy-client to master November 27, 2024 15:40
@hugoShaka hugoShaka force-pushed the hugo/kube-agent-updater-use-new-api branch from a07f29f to 7000435 Compare November 27, 2024 16:13
@hugoShaka hugoShaka added the no-changelog Indicates that a PR does not require a changelog entry label Nov 27, 2024
@hugoShaka hugoShaka force-pushed the hugo/kube-agent-updater-use-new-api branch from 7000435 to c50535f Compare November 27, 2024 20:04
@Tener Tener removed their request for review November 28, 2024 07:52
marcoandredinis
marcoandredinis approved these changes Nov 28, 2024
View reviewed changes
lib/automaticupgrades/version/versionget.go Outdated Show resolved Hide resolved
lib/automaticupgrades/version/proxy.go Show resolved Hide resolved
lib/automaticupgrades/maintenance/proxy.go Outdated Show resolved Hide resolved
lib/automaticupgrades/maintenance/proxy.go Show resolved Hide resolved
@hugoShaka hugoShaka enabled auto-merge November 29, 2024 01:02
@hugoShaka hugoShaka force-pushed the hugo/kube-agent-updater-use-new-api branch from 0eb01ed to ea70615 Compare December 4, 2024 18:23
@hugoShaka hugoShaka added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@hugoShaka hugoShaka added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 2967e4e Dec 4, 2024
39 checks passed
@hugoShaka hugoShaka deleted the hugo/kube-agent-updater-use-new-api branch December 4, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrato tigrato tigrato approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
automatic-upgrades no-changelog Indicates that a PR does not require a changelog entry size/md teleport-kube-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugoShaka @marcoandredinis @tigrato