Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Default config for storybook-controls, add storybook-actions #49239

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

kiosion
Copy link
Contributor

@kiosion kiosion commented Nov 19, 2024

Follow-up to #49098.

  • Set default config for storybook-controls add-on to prevent userContext Decorator showing as a Control for all Stories.
  • Tidy some incorrect types/controls for previously-added shared/controls/* stories.
  • Add @storybook/addon-actions & use in shared/controls/* stories to start. Add @storybook/preview-api's useArgs helper for syncing story args between components and the Controls UI.
    withActionsAddon

* Set some defaults for `storybook-controls` to prevent `userContext`
  Decorator showing as a Control for all Stories
* Add `@storybook/addon-actions` for displaying callbacks in UI, add to
  `shared/controls/*` stories
* Tidy some incorrect types/controls for `shared/controls/*` stories
@kiosion kiosion added the no-changelog Indicates that a PR does not require a changelog entry label Nov 19, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49239.d3pp5qlev8mo18.amplifyapp.com

@kiosion kiosion marked this pull request as ready for review November 19, 2024 22:14
@kiosion kiosion requested review from avatus and bl-nero November 25, 2024 17:29
@avatus
Copy link
Contributor

avatus commented Nov 25, 2024

sweet, thank you!

@kiosion kiosion added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@kiosion kiosion added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@kiosion kiosion added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit c3c0381 Nov 25, 2024
47 checks passed
@kiosion kiosion deleted the maxim/storybook-actions branch November 25, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants