Changing parker PDEATHSIG to SIGKILL #49207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktate
force-pushed
the
eriktate/fix-parker-deathsig
branch
from
0a09a9f to
75c935f
Compare
espadolini
approved these changes
Nov 19, 2024
espadolini
reviewed
Nov 19, 2024
| // if we ever need to run parkers on macOS or other platforms with no PDEATHSIG | ||
| // we should rework the parker to block on a pipe so it can exit when its parent | ||
| // is terminated | ||
| func parkerCommandOSTweaks(cmd *exec.Cmd) { |
There was a problem hiding this comment.
This needs a matching no-op function in reexec_other.go.
eriktate
force-pushed
the
eriktate/fix-parker-deathsig
branch
from
75c935f to
61a6b83
Compare
atburke
approved these changes
Nov 19, 2024
rosstimothy
approved these changes
Nov 19, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
eriktate
force-pushed
the
eriktate/fix-parker-deathsig
branch
from
61a6b83 to
c318a05
Compare
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts
teleport parkprocesses with a PDEATHSIG of SIGKILL instead of SIGQUIT. This should prevent leaking processes when the parentteleport execis killed too quickly afterteleport parkis spawned.changelog: Fixed an issue where
teleport parkprocesses could be leaked causing runaway resource usage.