Allow absolute links in the changelog #49201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
added
the
no-changelog
github-actions
bot
requested review from
mmcallister,
r0mant,
xinding33 and
zmb3
|
Depends on this |
|
🤖 Vercel preview here: https://docs-8a28glvg4-goteleport.vercel.app/docs |
ptgott
force-pushed
the
paul.gottschling/2024-11-19-changelog-abs-links
branch
from
4484826 to
a59d313
Compare
|
🤖 Vercel preview here: https://docs-icvn1cllq-goteleport.vercel.app/docs |
ptgott
force-pushed
the
paul.gottschling/2024-11-19-changelog-abs-links
branch
from
a59d313 to
4de85d2
Compare
|
🤖 Vercel preview here: https://docs-pia0wklhz-goteleport.vercel.app/docs |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ptgott
changed the title
ptgott
force-pushed
the
paul.gottschling/2024-11-19-changelog-abs-links
branch
from
4de85d2 to
60bebcc
Compare
This is because the changelog needs to include absolute docs links in order for our release process to run smoothly, since we need to sync release notes to the changelog. To do so, add a message control directive to the changelog. This change removes the comment that disables the remark messaging linter, since we have removed this custom linter in favor of Vale.
ptgott
force-pushed
the
paul.gottschling/2024-11-19-changelog-abs-links
branch
from
60bebcc to
e465771
Compare
|
🤖 Vercel preview here: https://docs-53yndoyvx-goteleport.vercel.app/docs |
|
🤖 Vercel preview here: https://docs-17t4mmg3m-goteleport.vercel.app/docs |
marcoandredinis
approved these changes
Nov 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
public-teleport-github-review-bot
bot
removed request for
mmcallister and
xinding33
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable absolute docs link linting in the changelog. This is because the changelog needs to include absolute docs links in order for our release process to run smoothly, since we need to sync release notes to the changelog.
This change removes the comment that disables the remark messaging linter, since we have removed this custom linter in favor of Vale.