Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Add Integration and DiscoveryConfig as labels to auto discovered RDS/EKS #49177

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

marcoandredinis
Copy link
Contributor

Backport #48986 to v16

Manual backport because in v16, the auto enrolled resources do not get the types.DiscoveryTypeLabel label assigned (they do in v17+).

…EKS (#48986)

* Add Integration and DiscoveryConfig as labels to auto discovered RDS/EKS

This PR adds two new labels to RDS and EKS resources:
- Integration
- DiscoveryConfig

Those labels help identify which Integration and DiscoveryConfig were
used to auto enroll the resources.

* remove unused code

* add missing discovery config labels for GCP and Azure
@marcoandredinis marcoandredinis added the no-changelog Indicates that a PR does not require a changelog entry label Nov 19, 2024
@github-actions github-actions bot added backport database-access Database access related issues and PRs discovery size/md labels Nov 19, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-49177.d212ksyjt6y4yg.amplifyapp.com

@marcoandredinis marcoandredinis added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@marcoandredinis marcoandredinis added this pull request to the merge queue Nov 20, 2024
Merged via the queue into branch/v16 with commit 50ae8f5 Nov 20, 2024
43 of 44 checks passed
@marcoandredinis marcoandredinis deleted the marco/v16/backport_48986 branch November 20, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport database-access Database access related issues and PRs discovery no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants