[teleport-update] Add systemd setup #49174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
added
the
no-changelog
sclevine
commented
Nov 19, 2024
| @@ -782,13 +786,5 @@ func (li *LocalInstaller) isLinked(versionDir string) (bool, error) { | |||
| return true, nil | |||
| } | |||
| } | |||
| linkData, err := readFileN(filepath.Join(li.LinkServiceDir, serviceName), maxServiceFileSize) | |||
There was a problem hiding this comment.
Note: removing this logic fixes linked-version detection via isLinked. Two versions can have the same file contents.
sclevine
force-pushed
the
sclevine/teleport-update-config
branch
from
e98623f to
82eecab
Compare
zmb3
approved these changes
Nov 20, 2024
vapopov
approved these changes
Nov 20, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
hugoShaka and
Joerger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a systemd service and timer for the
teleport-updatecommand.To install the service and timer, the
teleport-updatebinary executes theteleport-update setupsubcommand of the to-be-installedteleport-updatebinary during each update. This validates the new updater is a valid executable on the target platform, and ensures that the timer/service file match the new updater. Note that the hidden--self-setupflag can be passed to exec the same binary, to skip this validation.This is the seventh in a series of PRs implementing
teleport-update:Link Command: #48712
Update Command: #48244
Reloading with rollbacks: #47929
Linking: #47879
Enable Command: #47565
Initial scaffolding PR: #46418
The
teleport-updatebinary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/var/lib/teleport/versions.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289