[v17] build: Fix "make create-github-release" #49166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `create-github-release` make target to use "go run" to run the tool that creates the github release. This used to run a tool in this repository that was pre-built, so the "go run" was not needed before. Now the tool has moved to a separate repository, this is required.
Remove the `CHANGELOG` and `RELEASE_NOTES_GEN` vars that contained the name of a Go main package to run in favor of a straightforward "go run" command.
camscale
added
the
no-changelog
doggydogworld
approved these changes
Nov 19, 2024
r0mant
approved these changes
Nov 19, 2024
public-teleport-github-review-bot
bot
removed request for
zmb3 and
fheinecke
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
create-github-releasemake target to use "go run" to run thetool that creates the github release. This used to run a tool in this
repository that was pre-built, so the "go run" was not needed before.
Now the tool has moved to a separate repository, this is required.
Backport: #49111