Adding SSHPortForwarding to RoleOptions proto
#49165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bernardjkim,
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
eriktate
added
no-changelog
eriktate
force-pushed
the
eriktate/port-forward-config
branch
from
0f0277f to
52a3c3a
Compare
eriktate
force-pushed
the
eriktate/port-forward-config
branch
from
52a3c3a to
68c65e0
Compare
eriktate
force-pushed
the
eriktate/port-forward-config
branch
from
68c65e0 to
a9f61a9
Compare
|
🤖 Vercel preview here: https://docs-a38lfwqrd-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-7zclicyhf-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-auvan7y8n-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-bp1o04fn1-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-3r0agi8kj-goteleport.vercel.app/docs/ver/preview |
rosstimothy
reviewed
Nov 18, 2024
|
🤖 Vercel preview here: https://docs-ldyoxe0lf-goteleport.vercel.app/docs |
eriktate
force-pushed
the
eriktate/port-forward-config
branch
from
9124e7f to
4fc4a63
Compare
|
🤖 Vercel preview here: https://docs-m36rjw91c-goteleport.vercel.app/docs |
eriktate
force-pushed
the
eriktate/port-forward-config
branch
2 times, most recently
from
647e72b to
e5214e7
Compare
|
🤖 Vercel preview here: https://docs-o9f2yj7in-goteleport.vercel.app/docs |
eriktate
force-pushed
the
eriktate/port-forward-config
branch
from
e5214e7 to
fd68214
Compare
|
🤖 Vercel preview here: https://docs-ng46020w7-goteleport.vercel.app/docs |
rosstimothy
approved these changes
Nov 22, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
mmcallister,
zmb3,
bernardjkim,
hugoShaka,
xinding33 and
ptgott
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first for enabling individual access control of both local and remote port forwarding. It adds a
SSHPortForwardConfigmessage which is surfaced through theRoleOptionsmessage on any given role. It also marksPortForwardingas deprecated since we'll want to encourage leveragingSSHPortForwardinggoing forward. The legacyPortForwardingboolean will still be evaluated and prioritized overSSHPortForwardingfor backwards compatibility, which I'll include some more information about in the follow up PR implementing the new config options.No changelog since this doesn't actually change any functionality and I'll cover the new options in the next PR.