reduce locking test flake #49130
Merged
reduce locking test flake #49130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
added
flaky tests
no-changelog
zmb3
approved these changes
Nov 18, 2024
marcoandredinis
approved these changes
Nov 18, 2024
public-teleport-github-review-bot
bot
removed request for
espadolini and
mvbrock
espadolini
approved these changes
Nov 18, 2024
|
@fspmarshall See the table below for backport results.
|
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Lockingbackend compliance test was using a TTL of 5s for locks. TTLs that short have a tendency to produce flaky behavior in our CI due to the resource-constrained nature of the test env. This PR bumps the TTL to 30s. This has no effect on the "happy" path of the test, since no part of the test actually waits for a TTL to expire naturally.Note that it's difficult to prove whether or not the flake we've observed was only due to the short TTL, or if there is some additional unknown case that can manifest as an unexpected expired lock. Even if this change doesn't fully fix flaky
Lockingtests, it should at least let us be more confident that flake is the result of logical errors rather than dust motes settling on the water-logged TI-86 graphing calculator that we use to run our tests.