-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DiscoveryConfigStatus with EKS and RDS enrollment summary #48991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
backport/branch/v17
labels
Nov 14, 2024
marcoandredinis
force-pushed
the
marco/discover_add_integration_discoveryconfig_to_enrolled_resources
branch
from
November 18, 2024 16:48
7efa13b
to
2a5ee6f
Compare
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
from
November 18, 2024 16:53
484014c
to
ff67622
Compare
marcoandredinis
force-pushed
the
marco/discover_add_integration_discoveryconfig_to_enrolled_resources
branch
2 times, most recently
from
November 18, 2024 19:29
34d8f53
to
f176d32
Compare
Base automatically changed from
marco/discover_add_integration_discoveryconfig_to_enrolled_resources
to
master
November 18, 2024 20:16
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
3 times, most recently
from
November 19, 2024 18:42
4d5a568
to
5c19dbf
Compare
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
from
November 25, 2024 09:42
5c19dbf
to
b8fad9e
Compare
@mvbrock @rosstimothy Can you please take a look when you get a chance? |
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
from
November 25, 2024 10:31
b8fad9e
to
4f68dee
Compare
rosstimothy
reviewed
Nov 25, 2024
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
from
November 25, 2024 14:13
4f68dee
to
d694298
Compare
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
2 times, most recently
from
November 25, 2024 14:15
56f10d1
to
7576332
Compare
rosstimothy
reviewed
Nov 25, 2024
rosstimothy
approved these changes
Nov 25, 2024
This PR changes the DiscoveryService to add a new status report for RDS and EKS Clusters. It will, for each DiscoveryConfig/Integration, report how many resources were found, enrolled and failed to enroll.
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
from
November 28, 2024 13:52
95fc308
to
2c4e649
Compare
tigrato
approved these changes
Nov 28, 2024
public-teleport-github-review-bot
bot
removed the request for review
from mvbrock
November 28, 2024 14:22
marcoandredinis
force-pushed
the
marco/discover_update_stats_rdseks
branch
from
November 28, 2024 14:48
2c4e649
to
676b8a5
Compare
@marcoandredinis See the table below for backport results.
|
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
backport/branch/v17
discover
Issues related to Teleport Discover
discovery
no-changelog
Indicates that a PR does not require a changelog entry
size/md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the DiscoveryService to add a new status report for RDS
and EKS Clusters.
It will, for each DiscoveryConfig/Integration, report how many resources
were found, enrolled and failed to enroll.
Demo