Respect windows_desktop_labels for dynamic desktops #48941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
nklaassen
reviewed
Nov 15, 2024
| @@ -349,6 +349,7 @@ func validateRoleExpressions(r types.Role) error { | |||
| {"db_labels", types.KindDatabase}, | |||
| {"db_service_labels", types.KindDatabaseService}, | |||
| {"windows_desktop_labels", types.KindWindowsDesktop}, | |||
| {"windows_desktop_labels", types.KindDynamicWindowsDesktop}, | |||
There was a problem hiding this comment.
since GetLabelMatchers returns the same expression I think there's no need for this, it's just validating the same expression twice
There was a problem hiding this comment.
Should we leave it here for consistency sake?
zmb3
approved these changes
Nov 15, 2024
r0mant
approved these changes
Nov 15, 2024
public-teleport-github-review-bot
bot
removed request for
timothyb89 and
bl-nero
|
@probakowski See the table below for backport results.
|
This was referenced Nov 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other resources (like DB) we should respect labels when doing CRUD operations on dynamic windows desktops